Vulnerability advisory
GHSA-m7wr-2xf7-cm9p
pgx SQL Injection via Line Comment Creation
Also known as CVE-2024-27289GO-2024-2605
Severity
- CVSS 3.x
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H - CVSS 4.0
CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:P/VC:H/VI:H/VA:H/SC:N/SI:N/SA:N
Affected versions
| Affected | Fixed in |
|---|---|
| All versions before 4.18.2 | 4.18.2 |
| Affected | Fixed in |
|---|---|
| All versions before 4.18.2 | 4.18.2 |
Description
Impact
SQL injection can occur when all of the following conditions are met:
- The non-default simple protocol is used.
- A placeholder for a numeric value must be immediately preceded by a minus.
- There must be a second placeholder for a string value after the first placeholder; both must be on the same line.
- Both parameter values must be user-controlled.
e.g.
Simple mode must be enabled:
// connection string includes "prefer_simple_protocol=true"
// or
// directly enabled in code
config.ConnConfig.PreferSimpleProtocol = true
Parameterized query:
SELECT * FROM example WHERE result=-$1 OR name=$2;
Parameter values:
$1 => -42
$2 => "foo\n 1 AND 1=0 UNION SELECT * FROM secrets; --"
Resulting query after preparation:
SELECT * FROM example WHERE result=--42 OR name= 'foo
1 AND 1=0 UNION SELECT * FROM secrets; --';
Patches
The problem is resolved in v4.18.2.
Workarounds
Do not use the simple protocol or do not place a minus directly before a placeholder.
References
- Webgithub.com/jackc/pgx/security/advisories/GHSA-m7wr-2xf7-cm9p ↗
- Advisorynvd.nist.gov/vuln/detail/CVE-2024-27289 ↗
- Webgithub.com/jackc/pgx/commit/f94eb0e2f96782042c96801b5ac448f44f0a81df ↗
- Packagegithub.com/jackc/pgx ↗
- Webwww.sonarsource.com/blog/double-dash-double-trouble-a-subtle-sql-injection-flaw ↗